Fix update crash after code cleanup #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: the code cleanup introduced in PR percona#52 modified the original tuple in the update method instead of decrypting the tuple data into a copy. This caused data curruption crashes in some test. Fix: reintroduce the missing palloc to the update method. Fixes percona#62 Fixes percona#64
Co-authored-by: Andrew Pogrebnoi <[email protected]>
|
This PR broke the Update statements. |
dutow
added a commit
to dutow/postgres-tde-ext
that referenced
this pull request
Nov 13, 2023
Issue: with the fix in percona#67, pgtde decrypts tuples during update into a new memory region, and changes the t_data pointer to this new region. Because of this, later updates to tuple flags also happen in the new data, and the original persisted tuple flags are never updated. Fix: after the update statement is done with the decrypted data, restore the t_data pointer to the original. This way, flag changes happen where they should. Fixes percona#68
dutow
added a commit
to dutow/postgres-tde-ext
that referenced
this pull request
Nov 13, 2023
Issue: with the fix in percona#67, pgtde decrypts tuples during update into a new memory region, and changes the t_data pointer to this new region. Because of this, later updates to tuple flags also happen in the new data, and the original persisted tuple flags are never updated. Fix: after the update statement is done with the decrypted data, restore the t_data pointer to the original. This way, flag changes happen where they should. Fixes percona#68
dutow
added a commit
that referenced
this pull request
Nov 15, 2023
Issue: with the fix in #67, pgtde decrypts tuples during update into a new memory region, and changes the t_data pointer to this new region. Because of this, later updates to tuple flags also happen in the new data, and the original persisted tuple flags are never updated. Fix: after the update statement is done with the decrypted data, restore the t_data pointer to the original. This way, flag changes happen where they should. Fixes #68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: the code cleanup introduced in PR #52 modified the original tuple in the update method instead of decrypting the tuple data into a copy. This caused data curruption crashes in some test.
Fix: reintroduce the missing palloc to the update method.
Fixes #61
Fixes #62
Fixes #64